Pull requests for Code Merge
Description:
Use pull requests as a process for code merge. No commits are merged into the main branch by developers directly, instead pull requests are created and reviewed by colleagues first. Additionally tests should be executed as well within this process.
Links:
https://martinfowler.com/bliki/PullRequest.html
https://docs.github.com/de/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests
Keywords:
Pull Request, Code Review, Code Quality, Automated Tests
Motivation:
Every code changed is reviewed at least by one additional developer. Easily overlooked errors are reduced by that.
Requirements/Prerequisities:
Coderepository-Server with support for Pull Requests
Level:
concret: specific best practice (e.g. use microservice)
Application domain:
Data science (analysis & visualisation), Industry (Production), Mobility, Energy, Software engineering
Main phase:
Development: Implementation/Code/Build, Development: Testing
Related literature:
https://martinfowler.com/bliki/PullRequest.html (2021, Martin Fowler)
In which projects do/did you use this practice?
NodeDoc
Software Tester, Software Engineer, Researcher
>10 years of experiences
Software Competence Center Hagenberg
| 1. How do you rate the potential benefit for your projects? | 5 |
| 2. How often are you using that practice? | 5 |
| 3. What is the effort to introduce the practice in your project upfront? | 1 |
| 4. What is the effort to apply the best practice in your project daily basis? | 2 |
Questions 1, 3 and 4 (1 = Low, 5 = High)
Question 2 (1 = Never, 5 = Always)